Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrollment Index: Ensure header is always 2 lines. #1644

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Enrollment Index: Ensure header is always 2 lines. #1644

merged 1 commit into from
Aug 11, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 10, 2023 •
edited
Loading

fixes #1643

What this PR does

  • Widens the header column back to 8-col (like the rest of the app). Was previously using the 7-col narrowed width to force a line break. But it's wonky/bad cos it goes to 3 lines at narrowest widths.
  • Add a <br> in the header for both English and Spanish copy at the punctuation.
  • Ensure that this <br> doesn't have unintended consequences (mostly breaking into 3 lines). It doesn't.

Screenshots

All the widths

enrollment Kapture 2023-08-10 at 15 41 34
Click here to play gif

Desktop

image image

Mobile

image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 10, 2023 22:42
@machikoyasuda machikoyasuda self-assigned this Aug 10, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 10, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Aug 10, 2023
angela-tran
angela-tran previously approved these changes Aug 11, 2023
View reviewed changes
@machikoyasuda machikoyasuda force-pushed the fix/1643-enrollment-index-3-liner branch from 949abc7 to 269c3e3 Compare August 11, 2023 19:13
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Aug 11, 2023 •
edited
Loading

Rebased & merge conflict resolved.

@machikoyasuda machikoyasuda merged commit 97aecf3 into dev Aug 11, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1643-enrollment-index-3-liner branch August 11, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Bug: Enrollment Index - 2-line header always
2 participants
@machikoyasuda @angela-tran